Repository navigation
Remove bridge mode from RCTComponentData (#59264) - #59264
Closed
christophpurrer wants to merge 4 commits into
Closed
christophpurrer wants to merge 4 commits into
christophpurrer wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126575276. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59264 RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Differential Revision: D126575276
christophpurrer
force-pushed
the
export-D126575276
branch
from
October 21, 2026 04:37
f511242 to
0fc2703
Compare
meta-codesync
Bot
changed the title
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59264 RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Differential Revision: D126575276
christophpurrer
force-pushed
the
export-D126575276
branch
from
October 21, 2026 05:43
0fc2703 to
20f0e98
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Differential Revision: D126575276
christophpurrer
force-pushed
the
export-D126575276
branch
from
October 21, 2026 21:01
20f0e98 to
baa89fd
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Differential Revision: D126575276
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: Pull Request resolved: react#59264 RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Differential Revision: D126575276
christophpurrer
force-pushed
the
export-D126575276
branch
from
October 21, 2026 21:04
baa89fd to
3d63b43
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 21, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
Summary: Synthesize the injected launchOptions property and read getInitialURL state from it instead of self.bridge. Drops the last bridge read in this module along with its direct bridge header import. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126567470
Summary: Route JS-thread dispatch through the injected dispatchToJSThread block and read the injected performanceLogger. Delete the Views counter, which can only show zero since RCTViewRegistry exposes no enumeration, and reflow the HUD bar. Changelog: [iOS][Removed] - Remove the non-functional Views counter from the PerfMonitor HUD Reviewed By: shwanton Differential Revision: D126567926
Summary: Delete the always-false _isBridgeMode helper and fold its call sites to the bridgeless paths. Remove the no-op profiling bridge calls with their synchronize cascade, and simplify setExecutorClass to persist locally plus reload. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126574662
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Oct 22, 2026
Summary: RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly. Changelog: [Internal] Reviewed By: shwanton Differential Revision: D126575276
christophpurrer
force-pushed
the
export-D126575276
branch
from
October 22, 2026 19:37
3d63b43 to
305bde2
Compare
Collaborator
|
This pull request was successfully merged by @christophpurrer in ed7359a When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in ed7359a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTComponentData always runs bridgeless, so delete the always-false isBridgeMode helper, merge the manager properties into one strong reference, and use the injected event dispatcher directly.
Changelog:
[Internal]
Reviewed By: shwanton
Differential Revision: D126575276